Thank guys, we've got somewhere!! (took some provoking!)
I put the pump on a crate engine I had as it's easier than pulling the car apart each time.
Rebuilt again, haven't changed anything I've ever done apart from getting rid of the KSB, changing the timing piston and capping off the front as I didn't need a KSB on this car.
So after a lot of cranking and a lot of starting fluid I finally got it to fire up. It runs fine, smooth, everything working as it should.
However, it doesn't have a stable idle (unless it's at around 1500rpm). It also is very lazy to rev - as in if you pull it flat out (max travel screw removed) it will redline but it takes a while to build its way up there (almost like holding the throttle half way down and waiting). Terrible throttle response.
No amount of playing with the max fuel screw cures this, just more smoke and then a 3000rpm idle haha! - its almost like the control collar isn't being moved far enough.
Played with the throttle arm positioning on the throttle spline, no difference.
All I can think of is it's all to do with the governor system surely? I've always been skeptical as to what EXACTLY the effects are of the position of the "governor adjustment shaft". Normally I just count the threads and put it back where it was and its fine but this is the only thing I think could cause this - hear me out:
AFAIK - The static position of the sliding sleeve on the governor determines how far back the starting lever sits when the pump is stationary. This determines the positioning of the control collar for starting. If the sleeve is screwed in too far then the starting spring cannot allow the starting lever to 'lean' back far enough to move the control collar far enough for sufficient starting fuel - yes? (hence the terrible starting maybe?)
Then adding to this, once it has finally started and the flyweights are spinning, it has started to move the sliding sleeve slightly to push the starting lever back to the idle position (which is now too low hence the need for more on the max fuel screw to get it to idle). Then, as the throttle arm moves the tensioning lever for more fuel and the pump speed rises, this causes the flyweights to come out farther and push the sliding sleeve against the leverset to start to cut fuel delivery. As the governor shaft is set in too far, it is cutting fuel too early and you're constantly fighting against the governor hence why the pick up is so lazy as I believe it is stretching the main spring almost all the time. So all I can think of is to back the governor shaft out somewhat...what do you think to my theory? Sorry for another huge post